Skip to content

feat: journal run lifecycle transitions - #608

Merged
solomonneas merged 1 commit into
mainfrom
codex/568-2-lifecycle-integration
Jul 28, 2026
Merged

feat: journal run lifecycle transitions#608
solomonneas merged 1 commit into
mainfrom
codex/568-2-lifecycle-integration

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

This is slice 2 of #568. It connects the event journal added in #607 to existing run status writes while keeping run.json authoritative.

  • New runs opt in with BRIGADE_LIFECYCLE_JOURNAL=1.
  • Pre-lock bootstrap persists lifecycle_journal_requested without creating a journal.
  • The exact run-lock owner creates the journal and appends mapped status transitions before each snapshot update.
  • Legacy runs and flag-off runs remain snapshot-only.

Safety boundaries

Events contain only fields from the existing per-type allowlist. Raw errors, paths, prompts, provider output, and tool arguments do not enter lifecycle payloads. Journal errors fail closed before run.json advances.

This slice does not add replay, recovery repair, doctor integration, shadow comparison, or journal authority.

Verification

  • Focused lifecycle, detach, event, journal, resume, and lock suites: 393 passed.
  • ./scripts/verify: 4,841 passed, 3 skipped, 82.92% coverage.
  • Independent review found no Critical or Important issues after the detached-run regression fix.

Co-Authored-By: Cursor <cursoragent@cursor.com>

Co-Authored-By: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 34ec535f-814e-405e-a036-51ac057fd759

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 28, 2026
@solomonneas
solomonneas merged commit d29b0fd into main Jul 28, 2026
28 checks passed
@solomonneas
solomonneas deleted the codex/568-2-lifecycle-integration branch July 28, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant